Interleave printing with Repl output #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsoeldner
approved these changes
Oct 19, 2023
| @@ -1579,8 +1537,13 @@ runDesugarReplTopLevel | |||
| -> Lisp.ReplTopLevel i | |||
| -> m (DesugarOutput reso i (ReplTopLevel Name Type raw i)) | |||
| runDesugarReplTopLevel proxy pdb loaded = \case | |||
| Lisp.RTLTopLevel m -> | |||
| over dsOut RTLTopLevel <$> runDesugarTopLevel proxy pdb loaded m | |||
| -- We do not run desugar here for the repl. | |||
| @@ -189,20 +189,10 @@ data TopLevel name ty builtin info | |||
| deriving (Show, Functor) | |||
|
|
|||
| data ReplTopLevel name ty builtin info | |||
| = RTLTopLevel (TopLevel name ty builtin info) | |||
| | RTLDefConst (DefConst name ty builtin info) | |||
| = RTLDefConst (DefConst name ty builtin info) | |||
| | RTLDefun (Defun name ty builtin info) | |||
There was a problem hiding this comment.
Is this enough? How about modules?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto repl was not displaying results as we got them. This fixes this issue.